TD-6145 Backend and logic changes to support configurable self assessment declaration display #3405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rshrirohit
reviewed
Oct 30, 2025
| } | ||
|
|
||
| selfAssessmentService.IncrementLaunchCount(selfAssessmentId, delegateUserId); | ||
| if (selfAssessment.IncludeLearnerDeclarationPrompt) |
There was a problem hiding this comment.
@kevwhitt-hee what was the intention behind checking this thing here? If it is that we don't want to increment the count if a learner just launches a SA, sees the challenge screen and decides not to proceed, then what happens if the SA is configured not to show the challenge screen? At that time we won't increment the count according to the code here. Could you please tell us in detail about the intended logic so that Sherif could correct this.
rshrirohit
reviewed
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
https://hee-tis.atlassian.net/browse/TD-6145
Description
I introduced a migration to add a new IncludeLearnerDeclarationPrompt bit field to the SelfAssessments table.
I added a check to ensure that when the IncludeLearnerDeclarationPrompt property is set to true, the IncrementLaunchCount method is executed.
I added the IncludeLearnerDeclarationPrompt property to the SelfAssessment class.
I also updated the GetSelfAssessmentForCandidateById method to include the IncludeLearnerDeclarationPrompt field.
Finally, I updated the RequireProcessAgreementFilter to check whether the SelfAssessment is configured to display the learner declaration agreement.
Screenshots
When IncludeLearnerDeclarationPrompt is false
When IncludeLearnerDeclarationPrompt is true
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have:
Either:
Or: